Refactor: improve main manu option#170
Merged
sirmalloc merged 5 commits intosirmalloc:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
ysknsid25
commented
Feb 12, 2026
ysknsid25
commented
- Improved type safety: By specifying Record<MainMenuOption, string> as the descriptions object in getDescription, it is now guaranteed at compile time that descriptions are defined for all menu items.
- Strict handling: The MainMenuOption type is now also applied to handleMainMenuSelect in App.tsx, eliminating the risk of passing non-existent values in switch statements, etc.
- Enhanced Completion: When developing in the editor, valid strings for menu values are now auto-completed.
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Contributor
Author
Co-authored-by: Kanon <kengo071225@gmail.com>
Co-authored-by: Kanon <kengo071225@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.